Fix precedencegroup and operator decl lookup #30269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
force-pushed
the
hello-operator
branch
from
7b1ea26 to
465b032
Compare
hamishknight
force-pushed
the
hello-operator
branch
2 times, most recently
from
ef36934 to
c195306
Compare
hamishknight
force-pushed
the
hello-operator
branch
from
c195306 to
12ad80b
Compare
Query the SourceLookupCache for the operator decls, and use ModuleDecl::getOperatorDecls to clean up some code completion logic. In addition, this commit switches getPrecedenceGroups over to querying SourceLookupCache.
Use this instead of DeclKind in a few places.
hamishknight
force-pushed
the
hello-operator
branch
from
12ad80b to
a5fdb03
Compare
|
@swift-ci please test |
CodaFi
reviewed
Apr 13, 2020
| @@ -37,7 +37,7 @@ class NullablePtr { | |||
| template<typename OtherT> | |||
| NullablePtr(NullablePtr<OtherT> Other, | |||
| typename std::enable_if< | |||
| std::is_convertible<OtherT, T>::value, | |||
| std::is_convertible<OtherT *, T *>::value, | |||
There was a problem hiding this comment.
Let's split this one out separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.