[ObjC] Only Diagnose Selector Conflicts From Classes #30274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang 1200 appears to be returning us results from protocol declarations when we run lookup for an Objective-C selector. This code path can therefore see protocol requirements, and would erroneously diagnose witnesses from Swift subclasses of Objective-C classes as an attempt to conflict with the requirement in the protocol itself. This fix is super narrow to try to unblock our builds. Tests will follow once I can reduce the issue. Resolves rdar://60005962
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test Linux platform |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 1200 appears to be returning us results from protocol
declarations when we run lookup for an Objective-C selector. This code
path can therefore see protocol requirements, and would erroneously
diagnose witnesses from Swift subclasses of Objective-C classes
as an attempt to conflict with the requirement in the
protocol itself.
This fix is super narrow to try to unblock our builds. Tests will follow
once I can reduce the issue.
Resolves rdar://60005962