[fix] Eager specialization shouldn't optimize functions with ownership (yet) #30279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
changed the title
atrick
approved these changes
Mar 9, 2020
|
I discovered the issue when removing/adding ownership elimination passes to the pipeline. I'm not sure we have a standard way of catching passes like this. Could you trigger the CI? I haven't been granted access yet (@shahmishal friendly ping). |
|
@swift-ci smoke test and merge |
|
@zoecarver I think that there is a check in the utilities that prevents this. That being said, I am actually going to enable this soon on OSSA. I am fine with this going in for now. |
|
Yes, there's an assertion but, I think it's better to bail rather than fail in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
EagerSpecializerto skip functions with ownership. The next step for this pass supporting ownership is updatingGenericFuncSpecializer.