WinSDK: further extend the WinSock module #30295
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the new `afunix.h` header to the WinSock module which was introduced in the 10.0.17134 release.
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
|
What does this header provide, and is it backwards-deployable? |
|
@millenomi this provides AF_UNIX socket support. This is not really back-deployable, but, this is when building the module. If you do not use |
|
Got it. We use AF families in a bunch of places, and I was evaluating if we could adopt anything from here in eg SocketPort et al. |
|
The JIT regression is unrelated to this change, tracking in #29863. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new
afunix.hheader to the WinSock module which was introducedin the 10.0.17134 release.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.