Skip to content

[temp-rvalueopt] Teach how to promote fix_lifetime. #30299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Mar 9, 2020

In the case of copy_addr, we move it onto the source address and in the case of
a store, put it on the source object.

I just noted this pattern happening a bunch in the stdlib when I was looking
through it for ownership patterns.

In the case of copy_addr, we move it onto the source address and in the case of
a store, put it on the source object.

I just noted this pattern happening a bunch in the stdlib when I was looking
through it for ownership patterns.
@gottesmm gottesmm requested a review from atrick March 9, 2020 19:31
@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 9, 2020

This just cleans up the SIL.

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 9, 2020

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 9, 2020

@swift-ci benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Mar 9, 2020

Performance: -O

Regression OLD NEW DELTA RATIO
FlattenListFlatMap 6621 8745 +32.1% 0.76x (?)

Code size: -O

Performance: -Osize

Regression OLD NEW DELTA RATIO
String.data.LargeUnicode 93 108 +16.1% 0.86x (?)
 
Improvement OLD NEW DELTA RATIO
FlattenListFlatMap 6770 4707 -30.5% 1.44x (?)

Code size: -Osize

Performance: -Onone

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. The title scared me but I do believe this is correct.

@gottesmm gottesmm merged commit 20c0267 into swiftlang:master Mar 9, 2020
@gottesmm gottesmm deleted the pr-59c23cc931f2998f402e6f70662ccf3f70922c3b branch March 9, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants