test: add missing tool dependency #30313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests depend on the archiver, and may opt to use the LLVM archiver. Add a dependency for the test suite.
|
@swift-ci please smoke test |
dan-zheng
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Thanks!
Context: I ran into llvm-ar-related errors when running ninja check-swift:
FAIL: Swift(linux-x86_64) :: AutolinkExtract/import_archive.swift (658 of 6127)
******************** TEST 'Swift(linux-x86_64) :: AutolinkExtract/import_archive.swift' FAILED ********************
Script:
--
: 'RUN: at line 1'; rm -rf "/BinaryCache/Release/Linux-x86_64/toolchain/tools/swift/test-linux-x86_64/AutolinkExtract/Output/import_archive.swift.tmp" && mkdir -p "/BinaryCache/Release/Linux-x86_64/toolchain/tools/swift/test-linux-x86_64/AutolinkExtract/Output/import_archive.swift.tmp"
: 'RUN: at line 2'; /BinaryCache/Release/Linux-x86_64/toolchain/bin/swiftc -target x86_64-unknown-linux-gnu -toolchain-stdlib-rpath -module-cache-path '/BinaryCache/Release/Linux-x86_64/toolchain/swift-test-results/x86_64-unknown-linux-gnu/clang-module-cache' -emit-module -emit-module-path /BinaryCache/Release/Linux-x86_64/toolchain/tools/swift/test-linux-x86_64/AutolinkExtract/Output/import_archive.swift.tmp/empty.swiftmodule -module-name empty -module-link-name empty /SourceCache/llvm-project/swift/test/AutolinkExtract/empty.swift
: 'RUN: at line 3'; /BinaryCache/Release/Linux-x86_64/toolchain/bin/swiftc -target x86_64-unknown-linux-gnu -toolchain-stdlib-rpath -module-cache-path '/BinaryCache/Release/Linux-x86_64/toolchain/swift-test-results/x86_64-unknown-linux-gnu/clang-module-cache' -c /SourceCache/llvm-project/swift/test/AutolinkExtract/import_archive.swift -I /BinaryCache/Release/Linux-x86_64/toolchain/tools/swift/test-linux-x86_64/AutolinkExtract/Output/import_archive.swift.tmp -o /BinaryCache/Release/Linux-x86_64/toolchain/tools/swift/test-linux-x86_64/AutolinkExtract/Output/import_archive.swift.tmp/import_experimental.o
: 'RUN: at line 4'; llvm-ar cr /BinaryCache/Release/Linux-x86_64/toolchain/tools/swift/test-linux-x86_64/AutolinkExtract/Output/import_archive.swift.tmp/import_experimental.a /BinaryCache/Release/Linux-x86_64/toolchain/tools/swift/test-linux-x86_64/AutolinkExtract/Output/import_archive.swift.tmp/import_experimental.o
: 'RUN: at line 5'; /BinaryCache/Release/Linux-x86_64/toolchain/bin/swift-autolink-extract /BinaryCache/Release/Linux-x86_64/toolchain/tools/swift/test-linux-x86_64/AutolinkExtract/Output/import_archive.swift.tmp/import_experimental.a -o - | '/usr/bin/python2.7' '/SourceCache/llvm-project/swift/utils/PathSanitizingFileCheck' --sanitize BUILD_DIR='/BinaryCache/Release/Linux-x86_64/toolchain/tools/swift' --sanitize SOURCE_DIR='/SourceCache/llvm-project/swift' --use-filecheck '/BinaryCache/Release/Linux-x86_64/toolchain/bin/FileCheck' --check-prefix CHECK-elf /SourceCache/llvm-project/swift/test/AutolinkExtract/import_archive.swift
--
Exit Code: 127
Command Output (stderr):
--
/BinaryCache/Release/Linux-x86_64/toolchain/tools/swift/test-linux-x86_64/AutolinkExtract/Output/import_archive.swift.script: line 4: llvm-ar: command not found
--
********************
Testing Time: 100.16s
********************
Failing Tests (2):
Swift(linux-x86_64) :: AutolinkExtract/import_archive.swift
Swift(linux-x86_64) :: AutolinkExtract/empty_archive.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests depend on the archiver, and may opt to use the LLVM archiver.
Add a dependency for the test suite.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.