Revert "[Typechecker] Diagnose key paths with contextual root type but no leading dot" #30328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theblixguy Let's revert and go with parser identification of such cases, sounds good? |
|
@swift-ci please smoke test |
dan-zheng
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Thank you Pavel for proactively reverting to support our use case!
|
+1 thank you! |
|
Sounds good! I’ll put up a new PR shortly! |
|
No worries, take your time and thank you again! |
|
@theblixguy Just wanted to ask you whether you are still interested in working on alternative solution for this? |
|
@xedin Yes, sorry been a little busy in the past few days. I’ll put up a PR for the other approach shortly! |
|
@theblixguy No worries, take your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #30164