Use sizeof for buffer lengths in snprintf
#3037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than duplicating the constant value, use the `sizeof` operator to have the value propogate from the static buffer allocation. Any standards conforming implementation of `snprintf` will null-terminate the output unless the buffer is NULL (a zero-sized buffer is passed to the call). On Windows, where this is not the case, the function is named `_snprintf` which ensures that we do not accidentally end up with the incorrect behaviour.
|
@swift-ci Please test and merge |
kateinoigakukun
added a commit
to kateinoigakukun/swift
that referenced
this pull request
Sep 5, 2021
…1-04-27 Merge main 2021-04-27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
Rather than duplicating the constant value, use the
sizeofoperator to havethe value propogate from the static buffer allocation. Any standards conforming
implementation of
snprintfwill null-terminate the output unless the buffer isNULL (a zero-sized buffer is passed to the call). On Windows, where this is not
the case, the function is named
_snprintfwhich ensures that we do notaccidentally end up with the incorrect behaviour.