[fix][builtin] polymorphic builtins shouldn't inherit attributes #30435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
force-pushed
the
fix/builtin-is-dead
branch
from
e882852 to
e18147e
Compare
zoecarver
changed the title
|
@swift-ci please smoke test. |
gottesmm
reviewed
Mar 16, 2020
include/swift/AST/Builtins.def
Outdated
| @@ -113,7 +113,7 @@ BUILTIN_CAST_OR_BITCAST_OPERATION(SExtOrBitCast, "sextOrBitCast", "n") | |||
| #ifndef BUILTIN_BINARY_OPERATION_ALL | |||
| #define BUILTIN_BINARY_OPERATION_ALL(Id, Name, Attrs, Overload) \ | |||
| BUILTIN_BINARY_OPERATION_OVERLOADED_STATIC(Id, BUILTIN_BINARY_OPERATION_GENERIC_HELPER_STR(Name), Attrs, Overload) \ | |||
| BUILTIN_BINARY_OPERATION_POLYMORPHIC(Generic##Id, BUILTIN_BINARY_OPERATION_GENERIC_HELPER_STR(generic_##Name), Attrs) | |||
| BUILTIN_BINARY_OPERATION_POLYMORPHIC(Generic##Id, BUILTIN_BINARY_OPERATION_GENERIC_HELPER_STR(generic_##Name), "") | |||
There was a problem hiding this comment.
I would rather change BUILTIN_BINARY_OPERATION_POLYMORPHIC to not take that flag at all.
There was a problem hiding this comment.
Good idea. I'll do that.
gottesmm
approved these changes
Mar 17, 2020
zoecarver
force-pushed
the
fix/builtin-is-dead
branch
from
4126786 to
8f15946
Compare
|
@swift-ci please smoke test and merge. |
1 similar comment
|
@swift-ci please smoke test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all polymorphic builtins have empty attributes. Some attributes (such as read none) apply to the "regular" version of the builtin and not the polymorphic version. These builtins only exist in raw sil so, the error wasn't caught before. However, #30429 exposed the issue because mandatory combine runs during Onone. This is an NFC until #30429 lands.