Remove [extern_c] attribute from WinSDK module. #30527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've verified that all of the header files in this module already contain their own `extern "C"` blocks that are activated if compiling as C++. The additional [extern_c] attribute causes problems for some headers, like PathCch.h, that define additional overloads of functions when compiled as C++. The "global" [extern_c] essentially switches off name mangling with these overloads, which causes them to conflict with the functions they are overloading. See here for more context: swiftlang#30233 (comment) See here for an example of failures caused by the [extern_c]: https://ci-external.swift.org/job/swift-PR-windows/869/console (Search for "PathCch.h".)
|
@swift-ci Please test Windows platform |
|
CC @compnerd I'd appreciate it if you could take a look! |
|
Hmm, I wish I remembered what caused the “extern_c”, but, if it passes CI, sounds good to me. I’ll test it more thoroughly later. This fixes one of the two tests, the second test being generalized probably is the easiest thing, and we can opt for that and this over reverting I think of everything passes. |
compnerd
approved these changes
Mar 20, 2020
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've verified that all of the header files in this module already contain their own
extern "C"blocks that are activated if compiling as C++.The additional
[extern_c]attribute causes problems for some headers, likePathCch.h, that define additional overloads of functions when compiled as C++. The "global"[extern_c]essentially switches off name mangling for these overloads, which causes them to conflict with the functions they are overloading.See here for more context:
#30233 (comment)
See here for an example of failures caused by the [extern_c]:
https://ci-external.swift.org/job/swift-PR-windows/869/console
(Search for "PathCch.h".)