-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Remove redundant conditional check for true and false when the boolean is right there. #30534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke test and merge |
@akyrtzi can you please initiate the smoke-tests and merge tests? |
@swift-ci smoke test and merge |
1 similar comment
@swift-ci smoke test and merge |
Did! |
@CodaFi run the test and merge one more time please |
@swift-ci please smoke test |
Same here. You don’t have to rebase every time. @swift-ci please smoke test |
@swift-ci please smoke test |
Oh, are you rebasing every time the Windows bot fails? Unfortunately, that's a self-perpetuating cycle. The Windows bot currently doesn't auto-reschedule itself after you force push, so the first CI invocation after a force-push is bound to fail. Windows is not a hard gate you need to pass (yet) so don't worry about it. If the bot breaks, we'll just revert the PR and you can give it another go later. |
Here, let's get a real run in. @swift-ci test Windows |
⛵️ |
Basically, in many lines of code, there are tertiary functions that check if a statement is true, and if that statement is true, assign true to a boolean, and false if the statement is false. However, we can directly set the result of the statement to the boolean. It is much more cleaner and efficient that way.