-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[SourceKit/DocSupport] Update cross-import overlay symbols reported in the module doc-info request with their required bystanders. #30551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
Build failed |
Could you add some doc-comment in the test case, to ensure we don't include the "Available when B is imported with A" comment anywhere in the structured doc-comment info for declarations ? |
3e2f6d4
to
666d46f
Compare
@swift-ci please test |
Build failed |
Build failed |
@swift-ci please test OS X Platform |
…ls from cross-import overlays. Resolves rdar://problem/59446044
…ated for cross-import overlay decls are ignored. Unlike doc comments, they shouldn't be reported in the 'fully_annotated_decl' field.
666d46f
to
fe12ab2
Compare
@swift-ci please test |
Build failed |
Build failed |
@swift-ci please test OS X Platform |
NOTE: This PR includes the changes in #30521. Only the latest commit is new here. Ignore the rest.(Other PR since merged).Adds a new 'key.required_bystanders' entry to each symbol coming from a cross-import overlay. The value is a list of the bystander module names that need to be imported alongside the primary module for the cross-import overlay containing the symbol to be loaded.
Resolves rdar://problem/59446044