Skip to content

[SourceKit/DocSupport] Update cross-import overlay symbols reported in the module doc-info request with their required bystanders. #30551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

nathawes
Copy link
Contributor

@nathawes nathawes commented Mar 21, 2020

NOTE: This PR includes the changes in #30521. Only the latest commit is new here. Ignore the rest. (Other PR since merged).

Adds a new 'key.required_bystanders' entry to each symbol coming from a cross-import overlay. The value is a list of the bystander module names that need to be imported alongside the primary module for the cross-import overlay containing the symbol to be loaded.

Resolves rdar://problem/59446044

@nathawes nathawes requested a review from akyrtzi March 21, 2020 05:35
@nathawes
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 3e2f6d448d3f391d25739f5fdb25e0f723ee0a58

@akyrtzi
Copy link
Contributor

akyrtzi commented Mar 23, 2020

Could you add some doc-comment in the test case, to ensure we don't include the "Available when B is imported with A" comment anywhere in the structured doc-comment info for declarations ?

@nathawes nathawes force-pushed the cross-import-doc-info branch from 3e2f6d4 to 666d46f Compare March 24, 2020 05:08
@nathawes
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 3e2f6d448d3f391d25739f5fdb25e0f723ee0a58

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 3e2f6d448d3f391d25739f5fdb25e0f723ee0a58

@nathawes
Copy link
Contributor Author

@swift-ci please test OS X Platform

Nathan Hawes added 2 commits March 24, 2020 10:31
…ls from cross-import overlays.

Resolves rdar://problem/59446044
…ated for cross-import overlay decls are ignored.

Unlike doc comments, they shouldn't be reported in the 'fully_annotated_decl' field.
@nathawes nathawes force-pushed the cross-import-doc-info branch from 666d46f to fe12ab2 Compare March 24, 2020 17:31
@nathawes
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 666d46fcb12a8346485ad41ce9716fe0e729a54b

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 666d46fcb12a8346485ad41ce9716fe0e729a54b

@nathawes nathawes marked this pull request as ready for review March 24, 2020 18:50
@nathawes
Copy link
Contributor Author

@swift-ci please test OS X Platform

@nathawes nathawes merged commit b7bc7bc into swiftlang:master Mar 24, 2020
@nathawes nathawes deleted the cross-import-doc-info branch March 24, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants