SIL: reduced test case for SIL verifier failure #30562
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
CC: @gottesmm |
This is a reduced test case from the Foundation test suite which
triggers a SIL verifier error on Windows at least:
```
SIL verification failed: instruction isn't dominated by its operand: properlyDominates(valueI, I)
Verifying instruction:
%54 = struct_element_addr %53 : $*S, #S.args // users: %130, %116, %55
-> destroy_addr %54 : $*Array<Substring> // id: %130
```
compnerd
force-pushed
the
sil-verifier-failure
branch
from
cbd7063 to
55b9e43
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
When you run this with -sil-verify-all, what pass crashes? |
|
DestroyHoisting |
|
Thats @eeckstein |
|
The pass is the useful information. Next time -sil-verify-all failure happens, include that info please. |
|
@compnerd Thanks, I could reproduce this on Mac as well. Is there already a Jira ticket for this? |
|
Fixed in #30610 |
|
Thanks @eeckstein! No, I hadn't created the JIRA ticket yet, wasn't sure if it was a known issue or not. |
|
Never mind, I merged the fix already |
|
Thanks @eeckstein! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reduced test case from the Foundation test suite which
triggers a SIL verifier error on Windows at least:
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.