[AutoDiff upstream] Add derivative function witness/vtable entry SILGen. #30569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@differentiable` attribute on protocol requirements and non-final class
members now produces derivative function entries in witness tables and vtables.
This enables `witness_method` and `class_method` differentiation.
Existing type-checking rules:
- Witness declarations of `@differentiable` protocol requirements must have a
`@differentiable` attribute with the same configuration (or a configuration
with superset parameter indices).
- Witness table derivative function entries are SILGen'd for `@differentiable`
witness declarations.
- Class vtable derivative function entries are SILGen'd for non-final
`@differentiable` class members.
- These derivative entries can be overridden or inherited, just like other
vtable entries.
Resolves TF-1212.
|
@rjmccall @slavapestov: as SIL code owners, would you like to review this patch? |
|
@swift-ci Please test |
rxwei
approved these changes
Mar 22, 2020
|
@swift-ci Please test Windows platform |
|
All tests passed on a previous commit, so I'll just trigger smoke tests now. |
rxwei
approved these changes
Mar 22, 2020
|
Merging to unblock progress. Happy to address feedback later! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@differentiableattribute on protocol requirements and non-final classmembers now produces derivative function entries in witness tables and vtables.
This enables
witness_methodandclass_methoddifferentiation.Existing type-checking rules:
Witness declarations of
@differentiableprotocol requirements must have a@differentiableattribute with the same configuration (or a configurationwith superset parameter indices).
@differentiablewitness declarations.
Class vtable derivative function entries are SILGen'd for non-final
@differentiableclass members.vtable entries.
Resolves TF-1212.
See
test/AutoDiff/SILGen/{witness_,v}table.swiftfor examples.