[backport: 5.2] Add _mangledTypeName to allow round trips T->mangledName->T #30576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
ktoso
changed the title
|
Build failed |
|
Build failed |
jckarter
approved these changes
Mar 23, 2020
|
Failure: Whoops, my bad, looking into it |
ktoso
changed the title
ktoso
force-pushed
the
backport-5.2-wip-mangledTypeName
branch
from
777a30e to
f812dc3
Compare
…ups) Removing from backport as it's not a flag used on 5.2 it seems.
|
@swift-ci smoke test |
|
@swift-ci test |
|
Parking the 5.2 PR |
AnthonyLatsis
added
swift 5.2
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of
Add _mangledTypeName to allow round trips T->mangledName->T#30318The patch also applies cleanly on 5.1, so I'm wondering if we want to backport there as well...
I think personally I'm happy enough with 5.2 and asking users to upgrade.
cc @jckarter