[benchmark] Package.swift: Don’t trap on stray files under single-source/

[lorentey]

Make benchmark/Package.swift more robust against stray files (such as .DS_store) under benchmark/single-source/ etc.

Currently it traps with an Array index bounds error, leading to a difficult-to-debug build issue.

[lorentey]

@swift-ci smoke test

[lorentey]

@swift-ci benchmark

[swift-ci]

Performance: -O

Improvement	OLD	NEW	DELTA	RATIO
NSStringConversion.MutableCopy.UTF8	845	777	-8.0%	1.09x (?)
NSStringConversion.MutableCopy.Rebridge.UTF8	727	677	-6.9%	1.07x (?)

Code size: -O

Performance: -Osize

Code size: -Osize

Performance: -Onone

Improvement	OLD	NEW	DELTA	RATIO
ObjectiveCBridgeStubToNSDate2	1140	890	-21.9%	1.28x (?)
DictionaryOfAnyHashableStrings_lookup	5064	4416	-12.8%	1.15x (?)

Code size: -swiftlibs

How to read the data

The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview

  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

[gottesmm]

LGTM

[lorentey]

@swift-ci test Linux platform

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - 03e4f5f

[lorentey]

Ah, I missed the failure logs. :-(

@swift-ci please test linux platform

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - 03e4f5f

[lorentey]

@swift-ci test linux platform

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - 03e4f5f

[lorentey]

Ah, I finally caught the build failure in time to look at the logs. They're weird:

18:38:22 
/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swift/benchmark/utils/main.swift:17:8: error: no such module 'Ackermann'
18:38:22 import Ackermann
18:38:22        ^
18:38:22 Traceback (most recent call last):
18:38:22   File "/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swift/benchmark/scripts/build_script_helper.py", line 63, in <module>
18:38:22     main()
18:38:22   File "/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swift/benchmark/scripts/build_script_helper.py", line 57, in main
18:38:22     perform_build(args, swiftbuild_path, "debug", "Benchmark_Onone", "-Onone")
18:38:22   File "/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swift/benchmark/scripts/build_script_helper.py", line 39, in perform_build
18:38:22     shutil.copy(binpath, finalpath)
18:38:22   File "/usr/lib/python2.7/shutil.py", line 119, in copy
18:38:22     copyfile(src, dst)
18:38:22   File "/usr/lib/python2.7/shutil.py", line 82, in copyfile
18:38:22     with open(src, 'rb') as fsrc:
18:38:22 IOError: [Errno 2] No such file or directory: '/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/benchmarks-linux-x86_64/Benchmark_Onone/debug/SwiftBench'

[lorentey]

🤦‍♂️

[lorentey]

@swift-ci test