[ownership] Replace all uses outside of the SILOwnershipVerifier of LinearLifetimeChecker::checkValue() and make it a private implementation detail. #30602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
atrick
approved these changes
Mar 24, 2020
…inearLifetimeChecker::checkValue() and make it a private implementation detail. HOW THIS WAS DONE: I did this by refactoring the last usages of checkValue into a higher level API that uses checkValue as an implementation detail: completeConsumingUseSet(...). All of these places in MandatoryInlining/PredictableMemOpts all wanted behavior where we complete a set of consuming uses for a value, detecting if the consuming use is in a different loop nest from the value. WHY DO THIS: The reason why I wanted to do this is that checkValue is a lower level API that drives the actual low level computation. We shouldn't expose its interface to the LinearLifetimeChecker's users since it is our own private implementation detail that also has some sharp edges. AN ADDITIONAL BENEFIT: Additionally by hiding the declaration of checkValue, the last public use of LinearLifetimeError and ErrorBehaviorKind was not private. This allowed me to then move the declarations of those two to a private header (./lib/SIL/LinearLifetimeCheckerPrivate.h) and make their declarations private to LinearLifetimeChecker as well. As such, I renamed them to LinearLifetimeChecker::Error and LinearLifetimeChecker::ErrorBehaviorKind.
gottesmm
force-pushed
the
pr-ddf5c7c0e3c6e9ace5c3b695b19e43d13bb6ec3b
branch
from
b061d92 to
84232cf
Compare
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
@swift-ci test OS X platform |
|
@swift-ci test linux platform |
|
@swift-ci test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOW THIS WAS DONE: I did this by refactoring the last usages of checkValue into
a higher level API that uses checkValue as an implementation detail:
completeConsumingUseSet(...). All of these places in
MandatoryInlining/PredictableMemOpts all wanted behavior where we complete a set
of consuming uses for a value, detecting if the consuming use is in a different
loop nest from the value.
WHY DO THIS: The reason why I wanted to do this is that checkValue is a lower
level API that drives the actual low level computation. We shouldn't expose its
interface to the LinearLifetimeChecker's users since it is our own private
implementation detail that also has some sharp edges.
AN ADDITIONAL BENEFIT: Additionally by hiding the declaration of checkValue, the
last public use of LinearLifetimeError and ErrorBehaviorKind was not
private. This allowed me to then move the declarations of those two to a private
header (./lib/SIL/LinearLifetimeCheckerPrivate.h) and make their declarations
private to LinearLifetimeChecker as well. As such, I renamed them to
LinearLifetimeChecker::Error and LinearLifetimeChecker::ErrorBehaviorKind.