stdlib: COFF variant of "visibility" macro #3063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, LLVM supports the current three common object file formats (COFF, ELF, MachO). Unfortunately, COFF does not provide a compiler macro to identify the object file format. If neither `__MACH__` nor `__ELF__` is defined, then assume that the object file format being used is COFF. Within the COFF target handling, do not use `__declspec(dllexport)` for cygwin targets.
| #else | ||
| // __dllexport/__dllimport for Windows? | ||
| # error "Unimplemented object format" | ||
| # if defined(__CYGWIN__) |
There was a problem hiding this comment.
Why not #elif and keep the #error?
There was a problem hiding this comment.
As mentioned in the commit message, there is no preprocessing macro to identify COFF. __MACH__ identifies MachO, __ELF__ identifies ELF. Since LLVM only supports those three, make neither of them assume COFF.
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
Currently, LLVM supports the current three common object file formats (COFF,
ELF, MachO). Unfortunately, COFF does not provide a compiler macro to identify
the object file format. If neither
__MACH__nor__ELF__is defined, thenassume that the object file format being used is COFF. Within the COFF target
handling, do not use
__declspec(dllexport)for cygwin targets.