Skip to content

Don't try to look up info for a null TypeRef #30640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

tbkka
Copy link
Contributor

@tbkka tbkka commented Mar 25, 2020

This indirectly hardens the swift_reflection_infoForTypeRef API
against being invoked with a null TypeRef pointer. The API already
handles a nullptr being returned from TypeConverter::getTypeInfo
by converting it into a standard "UNKNOWN" type info descriptor.

Resolves rdar://60633988

This indirectly hardens the `swift_reflection_infoForTypeRef` API
against being invoked with a null TypeRef pointer.  The API already
handles a nullptr being returned from `TypeConverter::getTypeInfo`
by converting it into a standard "UNKNOWN" type info descriptor.

Resolves rdar://60633988
@tbkka
Copy link
Contributor Author

tbkka commented Mar 25, 2020

@swift-ci Please smoke test

@tbkka tbkka requested a review from mikeash March 25, 2020 18:40
@tbkka
Copy link
Contributor Author

tbkka commented Mar 25, 2020

@swift-ci Please smoke test Linux

@tbkka tbkka merged commit 94a0910 into swiftlang:master Mar 26, 2020
@mikeash
Copy link
Contributor

mikeash commented Mar 26, 2020

Thanks!

@tbkka tbkka deleted the tbkka-rdar60633988 branch October 16, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants