Skip to content

[SourceKit] Add an option to sort completion result #30653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2020
Merged

[SourceKit] Add an option to sort completion result #30653

merged 1 commit into from
Mar 27, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Mar 26, 2020

Defaults to false

rdar://problem/60799439

@rintaro
Copy link
Member Author

rintaro commented Mar 26, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 668c246be71d04b345b7a07f636627843f0e70b0

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 668c246be71d04b345b7a07f636627843f0e70b0

@rintaro rintaro force-pushed the sourcekit-completion-optionalsort-rdar60799439 branch from 668c246 to 54552f7 Compare March 26, 2020 20:56
@rintaro
Copy link
Member Author

rintaro commented Mar 26, 2020

swiftlang/sourcekit-lsp#258
@swift-ci Please test

@rintaro rintaro marked this pull request as ready for review March 26, 2020 21:22
@rintaro rintaro requested a review from akyrtzi March 26, 2020 21:23
@benlangmuir benlangmuir mentioned this pull request Mar 26, 2020
Merged
akyrtzi
akyrtzi reviewed Mar 26, 2020
View reviewed changes
test/SourceKit/CodeComplete/complete_sort_order.swift
Comment on lines +13 to +14
// RUN: %FileCheck -check-prefix=NAME_SORTED %s < %t.orig
// RUN: %FileCheck -check-prefix=NAME_UNSORTED %s < %t.orig.off
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a diff check for %t.orig vs %t.orig.off to ensure we got different behavior?
I suspect the test will still pass even if both invocations end up sorting the results.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect the test will still pass even if both invocations end up sorting the results.

Right.

I will add the diff test.

@rintaro
[SourceKit] Add an option to sort completion result
4294672 
Defaults to false

rdar://problem/60799439
@rintaro rintaro force-pushed the sourcekit-completion-optionalsort-rdar60799439 branch from 54552f7 to 4294672 Compare March 27, 2020 00:40
@rintaro
Copy link
Member Author

rintaro commented Mar 27, 2020

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Mar 27, 2020

swiftlang/sourcekit-lsp#258
@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Mar 27, 2020

swiftlang/sourcekit-lsp#258
@swift-ci Please smoke test Linux

@rintaro rintaro merged commit 49d72d7 into swiftlang:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akyrtzi akyrtzi akyrtzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rintaro @swift-ci @akyrtzi