[stdlib] StaticString: extension per conformance #30702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@milseman Please could you take a look, or suggest someone else to review this? Do you know if this kind of change to protocol conformances is allowed? |
|
I hope this is harmless @swift-ci test |
|
@swift-ci test source compatibility |
|
Debug failure is probably related to a recent type reconstruction patch. |
|
@slavapestov Please could you comment on whether this change is resilient? I couldn't find mention of it in either your blog post or the documentation. |
|
@swift-ci test source compatibility Debug |
|
The change is resilient. My comment was more about hoping the type checker wasn't relying on a specific ordering of declarations here. |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stylistic change, to prepare for additional protocol conformances.
(e.g. Make StaticString conform to Hashable)