Skip to content

Runtime: restrict behaviour to cygwin #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2016

Conversation

compnerd
Copy link
Member

What's in this pull request?

Resolved bug number: (SR-)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

__int128 is not available as an extension on MSVC nor clang for Windows.
Restrict the behaviour to cygwin only.

__int128 is not available as an extension on MSVC nor clang for Windows.
Restrict the behaviour to cygwin only.
@gribozavr
Copy link
Contributor

@swift-ci Please test and merge

@gribozavr gribozavr merged commit e2553c2 into swiftlang:master Jun 20, 2016
@tinysun212
Copy link
Contributor

@compnerd, @gribozavr, I'm sorry so late comment.
clang with -fms-extension (without -fms-compatibility) can recognize the __int128, and that worked well for 64bit MSVC.
I think this will work for 32bit MSVC, but will not return two word type for 64bit MSVC. (this means two uintptr_t type not DWORD). How about change this part work for both 32/64bit MSVC using #if/#endif?

@compnerd
Copy link
Member Author

Well, cl nor clang-cl seem to recognize __int128 when I tested it (on x86, x86_64, nor ARM). Does it actually work with cl?

@tinysun212
Copy link
Contributor

@compnerd, As you know, the driver clang-cl invokes compiler including flags -fms-extension, -fms-compatibility, and -fms-compatibility-version=xx. clang-cl does not recognize __int128.

I used clang with option -fms-extension and -fms-compatibility-version=19 without -fms-compatibility. The clang with the options could recognize __int128 and compile MSVC2015 (at least for Update 2) library headers with some more options.

This approach needed lesser patch to Swift source and could generate some Swift stdlib for 64bit MSVC.

@compnerd compnerd deleted the __int128-is-not-windows branch July 3, 2016 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants