Sema: Property wrapper storage wrappers ($foo) inherit 'final' bit from original property [5.2] #30750
+118
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
…om original property Otherwise, we would generate inconsistent vtable layouts for classes with static properties that have attached wrappers. The reason is that we normally force synthesis of the backing storage and storage wrapper for each instance property wrapper as part of computing the lowered stored properties. However, there was no such forcing for static properties. But since a static stored property (with an attached wrapper or otherwise) must be 'final', the real fix is to just ensure that the 'final' bit propagates to the storage wrapper as well. The backing storage property was already always final, so the issue did not arise there. Fixes <rdar://problem/59522703>, <https://bugs.swift.org/browse/SR-12429>.
slavapestov
force-pushed
the
final-static-property-wrapper-fix-5.2
branch
from
9f4328a to
de53a64
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci clean test |
tkremenek
approved these changes
Apr 2, 2020
AnthonyLatsis
added
swift 5.2
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we would generate inconsistent vtable layouts for classes
with static properties that have attached wrappers. The reason is that
we normally force synthesis of the backing storage and storage wrapper
for each instance property wrapper as part of computing the lowered
stored properties.
However, there was no such forcing for static properties. But since a
static stored property (with an attached wrapper or otherwise) must be
'final', the real fix is to just ensure that the 'final' bit propagates
to the storage wrapper as well.
The backing storage property was already always final, so the issue
did not arise there.
Fixes rdar://problem/59522703, https://bugs.swift.org/browse/SR-12429.