Sema: Infer error convention from @objc protocol requirements. #30763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Swift declaration witnesses an ObjC protocol requirement, its error convention needs to match the requirement. Furthermore, if there are different protocol requirements that the Swift method can witness, with different error conventions, we need to bail out because we can't simultaneously match all of them. Fixes rdar://problem/59496036 | SR-12201.
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test Linux |
|
Build failed |
|
@swift-ci Please test Linux |
|
Seems like we need to wait for #30776 to be merged first as it disables the failing test on Linux. Edit: I take it back, seems like the fix landed on master directly... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Swift declaration witnesses an ObjC protocol requirement, its error convention needs to
match the requirement. Furthermore, if there are different protocol requirements that the
Swift method can witness, with different error conventions, we need to bail out because we
can't simultaneously match all of them. Fixes rdar://problem/59496036 | SR-12201.