Skip to content

Add -Rcross-import option #30782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Add -Rcross-import option #30782

merged 1 commit into from
Apr 8, 2020

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Apr 2, 2020

It is an optional, user-accessible mechanism to have the compiler tell you what it’s cross-importing.

Resolves rdar://problem/60381893

@artemcm artemcm requested a review from beccadax April 2, 2020 23:17
@artemcm
Copy link
Contributor Author

artemcm commented Apr 2, 2020

@swift-ci Please test

Copy link
Contributor

@beccadax beccadax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few small issues, but the basic implementation is just right!

It is an optional, user-accessible mechanism to have the compiler tell you what it’s cross-importing.

Resolves rdar://problem/60381893
@artemcm
Copy link
Contributor Author

artemcm commented Apr 3, 2020

Code-review issues resolved.
@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 3, 2020

Build failed
Swift Test Linux Platform
Git Sha - 9970da6bcb82e71df200b6ede3b42011551ad9c4

@swift-ci
Copy link
Contributor

swift-ci commented Apr 3, 2020

Build failed
Swift Test OS X Platform
Git Sha - 9970da6bcb82e71df200b6ede3b42011551ad9c4

@artemcm
Copy link
Contributor Author

artemcm commented Apr 7, 2020

@brentdax ping.

Copy link
Contributor

@beccadax beccadax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants