Skip to content

[benchmark] Disable inlining of wCSIA in benchmark #30798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2020

Conversation

milseman
Copy link
Member

@milseman milseman commented Apr 3, 2020

... which gives us a better feel for when contiguity is unknown at the
call site.

... which gives us a better feel for when contiguity is unknown at the
call site.
@milseman
Copy link
Member Author

milseman commented Apr 3, 2020

@swift-ci please benchmark

@milseman
Copy link
Member Author

milseman commented Apr 3, 2020

@swift-ci please smoke test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 3, 2020

Performance: -O

Regression OLD NEW DELTA RATIO
String.data.Small 26 28 +7.7% 0.93x (?)
PrefixArrayLazy 13 14 +7.7% 0.93x (?)
 
Improvement OLD NEW DELTA RATIO
ObjectiveCBridgeStubToNSDate2 350 320 -8.6% 1.09x (?)
ObjectiveCBridgeStubToNSDateRef 2280 2120 -7.0% 1.08x (?)

Code size: -O

Performance: -Osize

Code size: -Osize

Performance: -Onone

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@milseman milseman merged commit c0960d3 into swiftlang:master Apr 5, 2020
@milseman milseman deleted the custom_bench_collection branch April 5, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants