Skip to content

[SR-12242] Apply to Arg involving ConstraintLocator::GenericArgument diagnostics improvement #30814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 6, 2020
Merged

[SR-12242] Apply to Arg involving ConstraintLocator::GenericArgument diagnostics improvement #30814

merged 6 commits into from
Apr 6, 2020

Conversation

LucianoPAlmeida
Copy link
Contributor

Just improving diagnostics for Generic Mismatch involving argument conversion.

cc @xedin @hborla :)

Resolves SR-12242.

hamishknight
hamishknight reviewed Apr 5, 2020
View reviewed changes
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-12242-generic-arg-diag-improvement branch from b0c11b0 to 75b7b7b Compare April 5, 2020 06:04
@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-12242-generic-arg-diag-improvement branch from 75b7b7b to b255b09 Compare April 5, 2020 06:06
@LucianoPAlmeida
Copy link
Contributor Author

Right, all set
I end up fixing assign here too since the PR is very small :)

@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-12242-generic-arg-diag-improvement branch 2 times, most recently from 36dc3f2 to 53ddf78 Compare April 5, 2020 16:44
hamishknight
hamishknight reviewed Apr 6, 2020
View reviewed changes
@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-12242-generic-arg-diag-improvement branch 2 times, most recently from 1086e4c to 7e1bf4c Compare April 6, 2020 12:31
@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-12242-generic-arg-diag-improvement branch from 7e1bf4c to 16ac70f Compare April 6, 2020 12:32
hamishknight
hamishknight approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@hamishknight
Copy link
Contributor

@swift-ci please test

@hamishknight
Copy link
Contributor

@swift-ci please test Windows

@hamishknight hamishknight merged commit 08904ff into swiftlang:master Apr 6, 2020
@LucianoPAlmeida LucianoPAlmeida deleted the SR-12242-generic-arg-diag-improvement branch April 6, 2020 23:15
@LucianoPAlmeida LucianoPAlmeida mentioned this pull request May 22, 2020
Merged
@LucianoPAlmeida LucianoPAlmeida mentioned this pull request Apr 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@hamishknight hamishknight hamishknight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucianoPAlmeida @hamishknight @xedin