Skip to content

Improve usability of _mangledTypeName with Any.Type arguments #30815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Apr 5, 2020

Minor follow up to #30318 which introduced _mangledTypeName.

We realized when using it in a real project that invoking it with an Any.Type was not working well since:

57: error: cannot convert value of type 'Any.Type' to expected argument type 'T.Type'

Since the API works on Any.Types anyway, it makes more sense to allow passing in anything.

Please sanity check @milseman @jckarter

@ktoso
Copy link
Contributor Author

ktoso commented Apr 6, 2020

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 6, 2020

Build failed
Swift Test Linux Platform
Git Sha - 5faf82c

@ktoso
Copy link
Contributor Author

ktoso commented Apr 6, 2020

Linux failure seems unrelated

13:00:03 <unknown>:0: warning: missing submodule 'CFURLSessionInterface'
13:00:03 
<unknown>:0: error: missing required module 'CFURLSessionInterface'
13:00:03 ninja: build stopped: subcommand failed.

Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this should be more flexible.

@ktoso
Copy link
Contributor Author

ktoso commented Apr 7, 2020

Thanks 👍

I don't (yet?) have merge powers, will see if I could get them or will ask someone.

@drexin
Copy link
Contributor

drexin commented Apr 7, 2020

@swift-ci test linux

@drexin
Copy link
Contributor

drexin commented Apr 7, 2020

@swift-ci smoke test linux

@drexin drexin merged commit 999b93b into swiftlang:master Apr 7, 2020
@ktoso ktoso deleted the wip-mangledTypeName branch April 7, 2020 04:07
@ktoso
Copy link
Contributor Author

ktoso commented Apr 7, 2020

Thanks for the help merging @drexin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants