Ignore transitive ObjC imports when cross-importing #30819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behavior change reduces the chance of unexpected and unwanted cross-imports being performed. Fixes rdar://problem/60554019.
|
@swift-ci please test |
|
@swift-ci Please Build Toolchain macOS Platform |
|
macOS Toolchain Install command |
|
This seems to have caused a regression on Windows: This looks like an actual issue in the code. |
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Apr 9, 2020
The commit added a broken header into the test which happened to pass due to ObjC behaviours accidentally leaking. Fix the header.
shahmishal
added a commit
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior change reduces the chance of unexpected and unwanted cross-imports being performed.
Fixes rdar://problem/60554019.