Skip to content

[benchmark] Change selection of non-skipped ParseInt benchmarks #30820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PatrickPijnappel
Copy link
Contributor

An update to #29988 in which benchmarks are selected as the representative 5. The new list is now:

  • Small signed decimal
  • UInt64 decimal
  • UInt64 hex
  • Small unsigned binary
  • Small signed uncommon radix

The original PR (inadvertently) had two large hex tests and no large decimal test as primary.

@PatrickPijnappel
Copy link
Contributor Author

PatrickPijnappel commented Apr 6, 2020

@swift-ci Please benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Apr 6, 2020

Performance: -O

Regression OLD NEW DELTA RATIO
ParseInt.IntSmall.UncommonRadix 313 340 +8.6% 0.92x (?)
String.data.Empty 24 26 +8.3% 0.92x (?)
 
Improvement OLD NEW DELTA RATIO
ParseInt.UIntSmall.Binary 821 504 -38.6% 1.63x
 
Added MIN MAX MEAN MAX_RSS
ParseInt.UInt64.Decimal 176 176 176
ParseInt.UInt64.Hex 302 312 307
 
Removed MIN MAX MEAN MAX_RSS
ParseInt.Int64.Hex 355 365 361
ParseInt.UInt32.Hex 263 264 263

Code size: -O

Performance: -Osize

Regression OLD NEW DELTA RATIO
String.data.LargeUnicode 66 71 +7.6% 0.93x (?)
 
Improvement OLD NEW DELTA RATIO
ParseInt.UIntSmall.Binary 662 569 -14.0% 1.16x
ParseFloat.Float.Exp 10 9 -10.0% 1.11x (?)
ObjectiveCBridgeStubToNSDateRef 2280 2120 -7.0% 1.08x (?)
ArrayAppendArrayOfInt 300 280 -6.7% 1.07x (?)
 
Added MIN MAX MEAN MAX_RSS
ParseInt.UInt64.Decimal 172 172 172
ParseInt.UInt64.Hex 319 319 319
 
Removed MIN MAX MEAN MAX_RSS
ParseInt.Int64.Hex 363 375 367
ParseInt.UInt32.Hex 285 301 290

Code size: -Osize

Performance: -Onone

Added MIN MAX MEAN MAX_RSS
ParseInt.UInt64.Decimal 5444 5493 5462
ParseInt.UInt64.Hex 4937 4984 4965
 
Removed MIN MAX MEAN MAX_RSS
ParseInt.Int64.Hex 5497 5552 5517
ParseInt.UInt32.Hex 6617 6644 6632

Code size: -swiftlibs

Benchmark Check Report
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@PatrickPijnappel
Copy link
Contributor Author

@swift-ci Please smoke test

@PatrickPijnappel PatrickPijnappel merged commit bd160ac into swiftlang:master Apr 6, 2020
@PatrickPijnappel PatrickPijnappel deleted the pick-parse-int-benchmarks branch April 6, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants