[AutoDiff] Add SR-12526 negative test. #30826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lift temporary cross-file derivative registration restriction. `@derivative` attribute type-checking simplications coming soon: TF-1099. Original function and derivative function must have same access level, with one exception: public original functions may have internal `@usableFromInline` derivatives.
Add negative test for SR-12526: `@derivative` attribute cross-module deserialization crash.
|
@swift-ci Please test |
rxwei
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lift temporary cross-file derivative registration restriction.
@derivativeattribute type-checking simplications coming soon: TF-1099.Original function and derivative function must have same access level, with one
exception: public original functions may have internal
@usableFromInlinederivatives.
WIP: #29987
Add negative test for SR-12526:
@derivativeattribute cross-moduledeserialization crash.
This blocks TF-1226: upstreaming derivatives in the
_Differentiationmodule.