Skip to content

[Build] Use simulator triples consistently #30843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DougGregor
Copy link
Member

The build systems that drive Swift compilation have been using the
"simulator" environment as part of the increasingly inaccurately
named "target triple" to specify simulator targets for several
years... except our own hand-rolled build system. Identify
simulator targets and append "-simulator" to their target
triples, and do so throughout our build and test infrastructure.

The build systems that drive Swift compilation have been using the
"simulator" environment as part of the increasingly inaccurately
named "target triple" to specify simulator targets for several
years... except our own hand-rolled build system. Identify
simulator targets and append "-simulator" to their target
triples.
The test was only checking iOS, and assuming that simulator targets
would behave the same way. Make the test amenable to both iOS and
iOS simulator.
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

swift-ci commented Apr 7, 2020

Build failed
Swift Test Linux Platform
Git Sha - bfbb758e3782d68bfc285753e1e0eac90e1389c9

@swift-ci
Copy link
Contributor

swift-ci commented Apr 7, 2020

Build failed
Swift Test OS X Platform
Git Sha - bfbb758e3782d68bfc285753e1e0eac90e1389c9

@DougGregor DougGregor force-pushed the consistent-simulator-triples branch from bfbb758 to 7a2c28d Compare April 7, 2020 16:57
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

swift-ci commented Apr 7, 2020

Build failed
Swift Test Linux Platform
Git Sha - bfbb758e3782d68bfc285753e1e0eac90e1389c9

@swift-ci
Copy link
Contributor

swift-ci commented Apr 7, 2020

Build failed
Swift Test OS X Platform
Git Sha - bfbb758e3782d68bfc285753e1e0eac90e1389c9

@DougGregor
Copy link
Member Author

DougGregor commented Apr 7, 2020

The Release source compatibility suite failed with a spurious error that's been bothering us:

fatal error: cannot open file '/Applications/Xcode.app/Contents/Developer/Platforms/AppleTVSimulator.platform/Developer/SDKs/AppleTVSimulator13.4.sdk/usr/include/Availability.h

@DougGregor
Copy link
Member Author

@swift-ci please test Linux

@swift-ci
Copy link
Contributor

swift-ci commented Apr 7, 2020

Build failed
Swift Test Linux Platform
Git Sha - 7a2c28d

@DougGregor
Copy link
Member Author

@swift-ci please test platform Linux

3 similar comments
@DougGregor
Copy link
Member Author

@swift-ci please test platform Linux

@DougGregor
Copy link
Member Author

@swift-ci please test platform Linux

@DougGregor
Copy link
Member Author

@swift-ci please test platform Linux

@DougGregor
Copy link
Member Author

@swift-ci please smoke test Linux

@DougGregor DougGregor merged commit b6df6ef into swiftlang:master Apr 8, 2020
@DougGregor DougGregor deleted the consistent-simulator-triples branch April 8, 2020 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants