-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Build] Use simulator triples consistently #30843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Use simulator triples consistently #30843
Conversation
The build systems that drive Swift compilation have been using the "simulator" environment as part of the increasingly inaccurately named "target triple" to specify simulator targets for several years... except our own hand-rolled build system. Identify simulator targets and append "-simulator" to their target triples.
The test was only checking iOS, and assuming that simulator targets would behave the same way. Make the test amenable to both iOS and iOS simulator.
@swift-ci please test |
@swift-ci please test source compatibility |
Build failed |
Build failed |
bfbb758
to
7a2c28d
Compare
@swift-ci please test |
@swift-ci please test source compatibility |
Build failed |
Build failed |
The Release source compatibility suite failed with a spurious error that's been bothering us:
|
@swift-ci please test Linux |
Build failed |
@swift-ci please test platform Linux |
3 similar comments
@swift-ci please test platform Linux |
@swift-ci please test platform Linux |
@swift-ci please test platform Linux |
@swift-ci please smoke test Linux |
The build systems that drive Swift compilation have been using the
"simulator" environment as part of the increasingly inaccurately
named "target triple" to specify simulator targets for several
years... except our own hand-rolled build system. Identify
simulator targets and append "-simulator" to their target
triples, and do so throughout our build and test infrastructure.