AST: Fix accessibility checking in opaque type archetype substitution logic #30847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
slavapestov
force-pushed
the
opaque-type-lowering-access-level-fix
branch
from
844c705 to
b94c7ce
Compare
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test source compatibility Debug |
… logic We were failing to replace opaque types with their underlying type upon encountering an internal type from the current module. This could happen when the internal type appeared in generic substitutions, for example when calling a protocol extension method. Fixes <rdar://problem/60951353>.
slavapestov
force-pushed
the
opaque-type-lowering-access-level-fix
branch
from
b94c7ce to
dbaa619
Compare
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
jckarter
reviewed
Apr 7, 2020
| if (dc->getParentModule() == typeDecl->getDeclContext()->getParentModule()) | ||
| return true; | ||
|
|
||
| return typeDecl->getEffectiveAccess() > AccessLevel::Internal; |
There was a problem hiding this comment.
Thanks for fixing this! Is there an existing resilience API we can use here to avoid duplicating visibility logic?
There was a problem hiding this comment.
None that I'm aware of at the moment. I have a follow-up PR with a couple of cleanups for a few other things I noticed while looking around at opaque type lowering, but not this function in particular. It's something we should chip away at over time.
aschwaighofer
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were failing to replace opaque types with their underlying type
upon encountering an internal type from the current module. This
could happen when the internal type appeared in generic substitutions,
for example when calling a protocol extension method.
Fixes rdar://problem/60951353.