Skip to content

IRGen: Type reconstruction supports opaque result types now #30861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 11, 2020
Merged

IRGen: Type reconstruction supports opaque result types now #30861

merged 5 commits into from
Apr 11, 2020

Conversation

slavapestov
Copy link
Contributor

No description provided.

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Copy link
Contributor Author

Oops, I guess it doesn’t quite work:

Failed to reconstruct type for $s7SwiftUI4ViewPAAE7paddingyQr12CoreGraphics7CGFloatVFQOyAcAE10preference3key5valueQrqd__m_5ValueAA13PreferenceKeyPQyd__tAaLRd__lFQOyAA6HStackVyAA05TupleC0VyAA5ImageV_AcAEADyQrAA4EdgeO3SetV_AGSgtFQOyAcAE14textFieldStyleyQrqd__AA04TexttU0Rd__lFQOyAA0vT0VyAA0V0VG_AA013RoundedBordervtU0VQo__Qo_AcAE9animationyQrAA9AnimationVSgFQOyAcAE06buttonU0yQrqd__AA015PrimitiveButtonU0Rd__lFQOyAA6ButtonVyA3_G_AA016BorderlessButtonU0VQo__Qo_SgtGG_0B009OffsetToplM0VQo__Qo_D
Original type:
(opaque_type address=0x7fe2a5b60fd8 conforms_to=SwiftUI.(file).View decl=SwiftUI.(file).View extension.padding
  (substitution_map generic_signature=<τ_0_0 where τ_0_0 : View>
    (substitution τ_0_0 -> some View)
    (conformance type=τ_0_0
      (abstract_conformance protocol=View)))
  (nested_type=Body <<unresolved>>))

@slavapestov slavapestov force-pushed the outdated-fixme branch 3 times, most recently from 47823b0 to 47a8c91 Compare April 9, 2020 21:12
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test Linux

@slavapestov
Sema: Force property wrappers in EmittedMembersRequest::evaluate()
2b93b5b 
Fixes <rdar://problem/61229365>.
@slavapestov
AST: Fix opaque type mangling used by type reconstruction
41ccedc 
Make sure we mangle opaque types using the same settings as the
debugger mangling (with OptimizeProtocolNames = false) to ensure
that we can reconstruct those names again.
@slavapestov
Serialization: Implement LocalDeclTableInfo::GetExternalKey()
43ee8ae 
This allows iterating over serialized decl tables, which is useful
for debugging.
@slavapestov
IRGen: Type reconstruction supports opaque result types now
f12b0d4
@slavapestov
IRGen: Fix simple_display(IRGenDescriptor)
0724c47
@slavapestov slavapestov force-pushed the outdated-fixme branch 2 times, most recently from d248a5c to 0724c47 Compare April 10, 2020 19:11
@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

1 similar comment
@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility Debug

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test Linux

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test macOS

@slavapestov slavapestov merged commit 365f0c7 into swiftlang:master Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@slavapestov