Skip to content

Add init_existential_metatype to CSE. #30872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Add init_existential_metatype to CSE. #30872

merged 1 commit into from
Apr 8, 2020

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Apr 8, 2020

So String decoding can be optimized.

Part 2/3 of optimizations for #30729

So String decoding can be optimized.
@atrick atrick requested a review from eeckstein April 8, 2020 04:52
@atrick
Copy link
Contributor Author

atrick commented Apr 8, 2020

@swift-ci test

@atrick
Copy link
Contributor Author

atrick commented Apr 8, 2020

@swift-ci benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Apr 8, 2020

Performance: -O

Regression OLD NEW DELTA RATIO
ArrayLiteral2 67 79 +17.9% 0.85x (?)
 
Improvement OLD NEW DELTA RATIO
ParseFloat.Float.Exp 10 9 -10.0% 1.11x (?)

Code size: -O

Performance: -Osize

Regression OLD NEW DELTA RATIO
String.data.Empty 24 26 +8.3% 0.92x (?)
SubstringFromLongStringGeneric 12 13 +8.3% 0.92x (?)
Set.isStrictSubset.Int.Empty 49 53 +8.2% 0.92x (?)
String.data.Small 25 27 +8.0% 0.93x (?)
Set.subtracting.Empty.Int 26 28 +7.7% 0.93x (?)
 
Improvement OLD NEW DELTA RATIO
PrefixWhileAnySeqCRangeIter 213 199 -6.6% 1.07x (?)

Code size: -Osize

Performance: -Onone

Regression OLD NEW DELTA RATIO
ObjectiveCBridgeStubNSDateRefAccess 3735 4092 +9.6% 0.91x (?)
 
Improvement OLD NEW DELTA RATIO
ArrayAppendLatin1Substring 34236 30888 -9.8% 1.11x (?)
ArrayAppendUTF16Substring 33804 30564 -9.6% 1.11x (?)
Breadcrumbs.MutatedUTF16ToIdx.ASCII 15 14 -6.7% 1.07x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@swift-ci
Copy link
Contributor

swift-ci commented Apr 8, 2020

Build failed
Swift Test Linux Platform
Git Sha - a22d0f2

@atrick
Copy link
Contributor Author

atrick commented Apr 8, 2020

@swift-ci test linux

@atrick
Copy link
Contributor Author

atrick commented Apr 8, 2020

Merging so I can post part 3/3 of this fix

@atrick atrick merged commit b5570a1 into swiftlang:master Apr 8, 2020
@atrick atrick deleted the cse-init-existential-metatype branch April 8, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants