[Sema] Eliminate duplication in CaseStmt typechecking for switch and do-catch #30879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…do-catch statements
owenv
commented
Apr 8, 2020
Comment on lines
+1075
to
+1082
| template <typename Iterator> | ||
| void checkSiblingCaseStmts(Iterator casesBegin, Iterator casesEnd, | ||
| CaseParentKind parentKind, | ||
| bool &limitExhaustivityChecks, Type subjectType) { | ||
| static_assert( | ||
| std::is_same<typename std::iterator_traits<Iterator>::value_type, | ||
| CaseStmt *>::value, | ||
| "Expected an iterator over CaseStmt *"); |
There was a problem hiding this comment.
Not sure if there's a better way to make this work with different kinds of iterators over CaseStmt*. Switch statements vend an OptionalTransformRange instead of an ArrayRef of cases in order to support conditional compilation blocks more easily.
slavapestov
approved these changes
Apr 8, 2020
|
@swift-ci Please smoke test |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing review feedback on #27776
The diff is a little messy, but this is just pulling shared logic out of
visitSwitchStmtandvisitDoCatchStmtand intocheckSiblingCaseStmts.