Skip to content

[Property Wrappers] Improve error recovery in buildStorageReference. #30896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hborla
Copy link
Member

@hborla hborla commented Apr 8, 2020

Bail out of buildStorageReference if the backing storage has an error type. This can happen if there's an invalid redeclaration of the property wrapper, for example.

Resolves: rdar://problem/61143435

@hborla hborla requested a review from slavapestov April 8, 2020 19:23
@hborla
Copy link
Member Author

hborla commented Apr 8, 2020

@swift-ci please smoke test

Bail out if the backing storage has an error type. This can happen
if there's an invalid redeclaration of the property wrapper, for
example.
@hborla hborla force-pushed the property-wrapper-invalid-redeclaration branch from 1932810 to 32c338f Compare April 8, 2020 19:45
@hborla
Copy link
Member Author

hborla commented Apr 8, 2020

@swift-ci please smoke test

@hborla hborla merged commit 008b33e into swiftlang:master Apr 8, 2020
@hborla hborla deleted the property-wrapper-invalid-redeclaration branch April 8, 2020 21:50
@rintaro
Copy link
Member

rintaro commented Apr 10, 2020

@hborla Could you consider adding this to swift-5.2-branch? It seems this is a pretty common crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants