Skip to content

Fix assert in MemAccessUtils isLetAccess #30913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Fix assert in MemAccessUtils isLetAccess #30913

merged 1 commit into from
Apr 9, 2020

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Apr 9, 2020

Assertion failed:
(accessedAddress == getAccessedAddress(accessedAddress) &&
"caller must find the address root"), function isLetAddress,
file /swift/lib/SIL/Utils/MemAccessUtils.cpp, line 63.

Teach the getAccessedAddress utility to iterate through nested access
markers with projections interposed.

Fixes rdar://problem/61464370
Crash in SILOptimizer/access_marker_verify.swift

Assertion failed:
(accessedAddress == getAccessedAddress(accessedAddress) &&
"caller must find the address root"), function isLetAddress,
file /Users/rjmccall/dev/swift/swift/lib/SIL/Utils/MemAccessUtils.cpp,
line 63.

Teach the getAccessedAddress utility to iterate through nested access
markers with projections interposed.

Fixes <rdar://problem/61464370>
Crash in SILOptimizer/access_marker_verify.swift
@atrick atrick requested a review from meg-gupta April 9, 2020 05:06
@atrick
Copy link
Contributor Author

atrick commented Apr 9, 2020

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit 83e176b into swiftlang:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants