Skip to content

[AutoDiff upstream] DifferentiationUnittest and some e2e tests #30915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

marcrasi
Copy link

@marcrasi marcrasi commented Apr 9, 2020

Adds 2 simple e2e tests and some lit subsitutions and unittest libraries
necessary to support them.

@marcrasi marcrasi requested review from rxwei and dan-zheng April 9, 2020 05:59
@marcrasi
Copy link
Author

marcrasi commented Apr 9, 2020

Note: depends on #30909 for tests to pass, so there's no point running tests before that gets merged.

Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting that tests pass!

@marcrasi marcrasi force-pushed the ad-upstream-tests-2 branch from 770d430 to 4e3eea1 Compare April 9, 2020 17:04
@@ -5,6 +5,7 @@ endif()
if(SWIFT_BUILD_SDK_OVERLAY)
# SwiftPrivateThreadExtras makes use of Darwin/Glibc, which is part of the
# SDK overlay. It can't be built separately from the SDK overlay.
add_subdirectory(DifferentiationUnittest)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, does this need if(SWIFT_ENABLE_EXPERIMENTAL_DIFFERENTIABLE_PROGRAMMING)? I'll add that here and see what happens.

@marcrasi marcrasi force-pushed the ad-upstream-tests-2 branch from 4e3eea1 to 3857192 Compare April 9, 2020 17:07
@marcrasi
Copy link
Author

marcrasi commented Apr 9, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 9, 2020

Build failed
Swift Test OS X Platform
Git Sha - 770d43028ec6657ecc005d8e0c81c12da821e674

@swift-ci
Copy link
Contributor

swift-ci commented Apr 9, 2020

Build failed
Swift Test Linux Platform
Git Sha - 770d43028ec6657ecc005d8e0c81c12da821e674

Adds 2 simple e2e tests and some lit subsitutions and unittest libraries
necessary to support them.
@marcrasi marcrasi force-pushed the ad-upstream-tests-2 branch from 3857192 to 43ca015 Compare April 9, 2020 18:33
@marcrasi
Copy link
Author

marcrasi commented Apr 9, 2020

@swift-ci please test

2 similar comments
@marcrasi
Copy link
Author

marcrasi commented Apr 9, 2020

@swift-ci please test

@marcrasi
Copy link
Author

marcrasi commented Apr 9, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 9, 2020

Build failed
Swift Test OS X Platform
Git Sha - 38571926d524551eaffd7b6f6c5decc15b534948

@marcrasi
Copy link
Author

marcrasi commented Apr 9, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 9, 2020

Build failed
Swift Test Linux Platform
Git Sha - 43ca015

@marcrasi
Copy link
Author

marcrasi commented Apr 9, 2020

@swift-ci please test linux

@marcrasi marcrasi merged commit ddef929 into swiftlang:master Apr 9, 2020
@marcrasi marcrasi deleted the ad-upstream-tests-2 branch April 9, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants