[Constraint solver] Migrate for-each statement checking into SolutionApplicationTarget #30924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ApplicationTarget. Pull the entirety of type checking for for-each statement headers (i.e., not the body) into the constraint system, using the normal SolutionApplicationTarget-based constraint generation and application facilities. Most of this was already handled in the constraint solver (although the `where` filtering condition was not), so this is a smaller change than it looks like.
The last client of this listener-based interface has been refactored, so remove it.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci smoke test platform Linux |
|
@swift-ci please test source compatibility |
|
@swift-ci smoke test platform Linux |
|
@swift-ci smoke test Linux |
|
@swift-ci smoke test Linux |
|
Now that swiftlang/llvm-project#1057 is merged maybe Linux tests will run cleanly. |
|
@swift-ci smoke test Linux |
1 similar comment
|
@swift-ci smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull the entirety of type checking for for-each statement headers (i.e., not the
body) into the constraint system, using the normal
SolutionApplicationTarget-basedconstraint generation and application facilities. Most of this was already handled
in the constraint solver (although the
wherefiltering condition was not), sothis is a smaller change than it looks like.
This was the last client of
ExprTypeCheckListener, so remove that listener interface.