[SourceKit] Avoid one memcpy on potentially big sourcekit response data #30929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
rintaro
force-pushed
the
sourcekit-setcustombuffer-avoidmemcopy
branch
from
69478e1 to
8a5b4ff
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test Linux |
benlangmuir
reviewed
Apr 10, 2020
|
|
||
| char *start = result->getBufferStart(); | ||
| char *start = result->getBufferStart() + sizeof(uint64_t); |
| BufferPtr(llvm::MemoryBuffer::getMemBufferCopy( | ||
| MemBuf->getBuffer(), | ||
| MemBuf->getBufferIdentifier())) | ||
| SKDCustomData(std::unique_ptr<llvm::MemoryBuffer>& MemBuf) |
There was a problem hiding this comment.
You are changing this from copying the buffer to taking ownership of it, so the type should be rvalue reference (&&) or else by value, not by lvalue reference.
A kind indicator is needed before the actual data when custom data are storeed as xpc dictionary values. Instead of prepending the kind bit by copying data to another buffer, let the data producers include it in the created data.
rintaro
force-pushed
the
sourcekit-setcustombuffer-avoidmemcopy
branch
from
8a5b4ff to
69971af
Compare
benlangmuir
approved these changes
Apr 10, 2020
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A kind indicator is needed before the actual data when custom data are stored as xpc dictionary values. Instead of prepending the kind bit by copying data to another buffer, let the data producers include it in the created data.