Skip to content

[AutoDiff upstream] add more differentiation tests #30933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

marcrasi
Copy link

@marcrasi marcrasi commented Apr 9, 2020

  • Two control-flow related SILOptimizer tests.
  • One control-flow validation test.
  • One reabstraction validation test.

I needed to append _l to the names of some of the CHECKs for the control-flow generated types in differentiation_control_flow_sil.swift. And I had to add import _Differentiation. Other than that, the tests are unmodified from tensorflow branch.

@marcrasi marcrasi requested review from rxwei and dan-zheng April 9, 2020 22:57
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@marcrasi
Copy link
Author

marcrasi commented Apr 9, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6aef110

@marcrasi
Copy link
Author

@swift-ci please test linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6aef110

@marcrasi
Copy link
Author

@swift-ci please test linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6aef110

@marcrasi
Copy link
Author

@swift-ci Please test Linux

@marcrasi marcrasi merged commit 99356cd into swiftlang:master Apr 13, 2020
@marcrasi marcrasi deleted the ad-upstream-tests-3 branch April 13, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants