Skip to content

[Sema] Diagnose use of implementation-only property wrappers #30939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2020
Merged

[Sema] Diagnose use of implementation-only property wrappers #30939

merged 1 commit into from
Apr 10, 2020

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Apr 10, 2020

We already ban all structs from declaring that comes from implementation-only imports. Until now we missed property wrappers, they were just dropped in deserialization.

Resolves rdar://problem/59403617

@artemcm artemcm requested a review from xymus April 10, 2020 01:31
@artemcm
Copy link
Contributor Author

artemcm commented Apr 10, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4d44f0801f6c77f91d63ffdd8d5f43ec8bbbda3d

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4d44f0801f6c77f91d63ffdd8d5f43ec8bbbda3d

@CodaFi
Copy link
Contributor

CodaFi commented Apr 10, 2020

LLDB broke

@swift-ci test

@CodaFi
Copy link
Contributor

CodaFi commented Apr 10, 2020

@swift-ci test source compatibility

xymus
xymus approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@xymus xymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing test is expected to fail and that part of it should be removed. Hopefully it was just an over-reduced case.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4d44f0801f6c77f91d63ffdd8d5f43ec8bbbda3d

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4d44f0801f6c77f91d63ffdd8d5f43ec8bbbda3d

@artemcm
[Sema] Diagnose use of implementation-only property wrappers
efdfcee 
We already ban all structs from declaring storage that comes from implementation-only imports. Until now we missed property wrappers, they were just dropped in deserialization.

Resolves rdar://problem/59403617
@artemcm artemcm force-pushed the ImplOnlyPropertyWrappers branch from 4d44f08 to efdfcee Compare April 10, 2020 18:21
@artemcm
Copy link
Contributor Author

artemcm commented Apr 10, 2020

I updated the PR with the test change that should resolve the OS X failure. Not sure what the Linux lldb failure is about yet, will see what happens.
@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4d44f0801f6c77f91d63ffdd8d5f43ec8bbbda3d

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4d44f0801f6c77f91d63ffdd8d5f43ec8bbbda3d

@artemcm artemcm merged commit e3ce6f7 into swiftlang:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xymus xymus xymus approved these changes

@CodaFi CodaFi CodaFi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artemcm @swift-ci @CodaFi @xymus