Platform: alias math constants on Windows #30940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The non-C/C++ standard defined math constants require `-Xcc -D_USE_MATH_DEFINES` when using the `ucrt` module. Instead, provide them through the wrapper `MSVCRT` module as aliases so that the user does not need to be aware of this in practice. Repairs the Windows build of `_Differentiation`.
|
@swift-ci please test Windows platform |
|
@swift-ci please test macOS platform |
|
Please test with following PRs: @swift-ci please test Linux platform |
dan-zheng
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-C/C++ standard defined math constants require
-Xcc -D_USE_MATH_DEFINESwhen using theucrtmodule. Instead,provide them through the wrapper
MSVCRTmodule as aliases so that theuser does not need to be aware of this in practice.
Repairs the Windows build of
_Differentiation.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.