Revert "[PrintAsObjC] Don't include the module for empty extensions" #30944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8f01b2c.
|
@swift-ci please smoke test |
…Only types" This reverts commit 4e8867e.
|
@swift-ci please smoke test |
xymus
approved these changes
Apr 13, 2020
|
@swift-ci please smoke test Linux |
This was referenced Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8f01b2c. While it is absolutely reasonable to prune the generated Swift header by not emitting unnecessary module imports,
some Objective-C code has come to rely on these. Fixes rdar://problem/61415191