[Diagnostics] Introduce getLoc and getSourceRange to failure diagnostic
#30967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still a draft because I need to clean up some things here and there but I'd want to get early opinion on the changes. Please take a look! |
|
The idea is that |
xedin
force-pushed
the
add-loc-to-failure-diagnostic
branch
from
180a5a7 to
faf046a
Compare
…nchor` Some of the diagnostics have special rules about anchor location, let's make `getAnchor` virtual and allow sub-class to override default implementation.
Split `emitDiagnostic` into `emitDiagnostic` and `emitDiagnosticAt`. Refactor existing diagnostics to use new methods and avoid passing location when possible.
xedin
force-pushed
the
add-loc-to-failure-diagnostic
branch
from
faf046a to
ce324d3
Compare
|
@hamishknight Thanks for the review, I've fixed both problems you have mentioned. |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
|
Since there is no opposition here I'm going to merge this and next up is removal of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the diagnostics have special rules about anchor location,
let's make
getAnchorvirtual and allow sub-class to overridedefault implementation.
Split
emitDiagnosticintoemitDiagnosticandemitDiagnosticAt,where former passes
getLocinternally.Refactor existing diagnostics to use new methods and avoid passing
location when possible.