[DiagnosticVerifier] Explicitly convert a StringRef into a std::string. #30973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newer llvm StringRef library has removed the implicit StringRef to std::string conversion. (See: llvm/llvm-project@adcd026) This patch also uses a StringRef to compare another StringRef eliminating the need to perform a StringRef to std::string conversion. I am concerned that StringRef's are being stored in ExpectedEducationalNotes, but as long as the StringRef does not out live the definition this is totally cool then.
owenv
approved these changes
Apr 11, 2020
|
@swift-ci please smoke test |
Fantastic! Thanks for the info and the approval. |
|
It looks like the failure for the Windows test is not related (there was a previous failure prior to testing this patch: https://ci-external.swift.org/job/swift-PR-windows/1594/console)). |
|
Windows failure should be fixed now. @swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer llvm StringRef library has removed the implicit StringRef to
std::string conversion. (See: llvm/llvm-project@adcd026)
This patch also uses a StringRef to compare another StringRef
eliminating the need to perform a StringRef to std::string conversion.
I am concerned that StringRef's are being stored in
ExpectedEducationalNotes, but as long as the StringRef does not out live
the definition this is totally cool then. (cc: @owenv)
(I do not have privs so I cannot run the tests).