[android] Mark large_string_array as unsupported in Android-ARMv7 #30987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems that the test takes more than 5 minutes to finish, so the timeout is triggered. Remove the test from the supported set for Android-ARMv7. Instead of using XFAIL, use UNSUPPORTED to avoid spending 5 minutes waiting for the timeout to occur. I don't think a lot of people will be able to spend time to find out what's happening in a niche platform. To make more clear what was happening, include a message if the timeout.py script actually times out. Otherwise the error is a cryptic "FileCheck error: '-' is empty.". Also fix the shebang and import the print function from __future__ to avoid using the old print-chevron.
drodriguez
force-pushed
the
android-disable-large-string-array
branch
from
fee09fd to
edfaba4
Compare
|
@swift-ci please smoke test |
|
I just seen #30991, so this one seems unnecessary if every 32 bit platform is disabled. The small improvement to the timeout script can be reused if someone is interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that the test takes more than 5 minutes to finish, so the timeout
is triggered. Remove the test from the supported set for Android-ARMv7.
Instead of using XFAIL, use UNSUPPORTED to avoid spending 5 minutes
waiting for the timeout to occur. I don't think a lot of people will be
able to spend time to find out what's happening in a niche platform.
To make more clear what was happening, include a message if the
timeout.py script actually times out. Otherwise the error is a cryptic
"FileCheck error: '-' is empty.". Also fix the shebang and import the
print function from future to avoid using the old print-chevron.
This appeared in https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android/6082/ for Android ARMv7.
I am still trying to get a number in my machine about the amount of time. It has been already 12 minutes with no result, so there's probably a problem somewhere.