[SourceKit] Don't use clang build sessions when validation is disabled #31013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
commented
Apr 14, 2020
| // RUN: -shell -- cp -R %S/../Inputs/build_session/Frameworks_modified/FooHelper.framework %t/System/Frameworks/ == \ | ||
| // RUN: -shell -- echo '## TWO' == \ | ||
| // RUN: -req=sema %s -- %s -D TWO -Fsystem %t/System/Frameworks -module-cache-path %t/ModuleCache -Xfrontend -disable-modules-validate-system-headers \ | ||
| // RUN: | tee %t.result | %FileCheck %s --check-prefix=CHECK_DISABLED |
There was a problem hiding this comment.
Remove tee %t.result | . That was for debugging.
rintaro
force-pushed
the
sourcekit-buildsession-implicit-rdar61075677
branch
from
c8e5c71 to
d868e51
Compare
Don't use '-fbuild-session-timestamp' if '-disable-modules-validate-system-headers' is specified. Since system header validation happens under *OR* condition of 'ValidateSystemInputs' and 'ModulesValidateOncePerBuildSession', using build sessions effectively overrides it. rdar://problem/61075677
rintaro
force-pushed
the
sourcekit-buildsession-implicit-rdar61075677
branch
from
d868e51 to
f943a88
Compare
|
@swift-ci Please smoke test |
akyrtzi
approved these changes
Apr 14, 2020
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use
-fbuild-session-timestampif-disable-modules-validate-system-headersis specified.Since system header validation happens under OR condition of
ValidateSystemInputsandModulesValidateOncePerBuildSession, using build sessions effectively overrides-disable-modules-validate-system-headers.rdar://problem/61075677