Requestify implicit imports #31016
Merged
Requestify implicit imports #31016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility Debug |
|
Debug failure seems like a consequence of Slava's patches to opaque type reconstruction. I wouldn't worry about it. |
CodaFi
reviewed
Apr 15, 2020
CodaFi
reviewed
Apr 15, 2020
Check whether the user has provided a valid identifier when parsing the options. Also make ImplicitImportModuleNames a private member of FrontendOptions to prevent mutation after being parsed.
Add ModuleImplicitImportsRequest, which computes the modules that should be implicitly imported by each file of a given module. Use this request in import resolution to add all the necessary implicit imports. The request computes the implicit imports by consulting the ImplicitImportInfo, which ModuleDecl can now be created with. This allows us to remove uses of `SourceFile::addImports` in favor of adding modules needed to be implicitly imported to the ImplicitImportInfo.
The associated comment appears to outdated. Make sure we continue to record implicit imports for empty files.
Temporarily replace with `SourceFile::setImports` until import resolution is requestified. Now imports are only set once for a given SourceFile. Because we're now asserting in more places that import resolution must have run before querying imports, this commit also adds `getCachedUnderlyingType` to TypeAliasDecl to stop the ASTDumper from trying to query imports for a -dump-parse invocation.
hamishknight
force-pushed
the
a-balance-of-payments-deficit
branch
from
92ef6bc to
92103a7
Compare
|
Rebased to resolve a merge conflict. @swift-ci please test |
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ModuleImplicitImportsRequest, which computes the modules that should be implicitly imported by each file of a given module by consulting theImplicitImportInfothat it's created with. Use this request in import resolution to add all the necessary implicit imports.Along with swiftlang/llvm-project#1079, this allows us to remove
SourceFile::addImports, ensuring that a file's imports are computed only once.Note I'm not planning on merging this until after the 5.3 re-branch.